Add test case for issue #265 (ALPN + large body) #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduces the bug where POST requests with bodies >64KB fail when using protocols: [:http1, :http2] due to HTTP/2 flow control not being implemented in the HTTP/1 pool. The failing test is marked with @tag :skip for future work. Two passing control tests confirm HTTP/2-only and HTTP/1-only configurations work correctly.
Change 65535 to 65_535 to comply with Credo's readability check that numbers larger than 9999 should use underscore separators.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test that reproduces the bug where POST requests with bodies >64KB fail when using protocols: [:http1, :http2].
The failing test is marked with @tag :skip. Two passing control tests confirm HTTP/2-only and HTTP/1-only configurations work correctly with large bodies.
Relates to #265